Comments on: Improving Django performance with better caching http://www.peterkrantz.com/2008/improving-django-cache-performance/ A blog about technology, visualization, music and unmanned vehicle experiments Thu, 26 Aug 2010 18:28:31 +0000 hourly 1 http://wordpress.org/?v=3.0.1 By: Evgeniy http://www.peterkrantz.com/2008/improving-django-cache-performance/comment-page-1/#comment-2647 Evgeniy Thu, 22 Oct 2009 05:13:04 +0000 http://www.peterkrantz.com/?p=231#comment-2647 This patch applied to the trunk? Or GET requests still not cached? This patch applied to the trunk? Or GET requests still not cached?

]]> By: Emil Stenström http://www.peterkrantz.com/2008/improving-django-cache-performance/comment-page-1/#comment-2351 Emil Stenström Mon, 03 Nov 2008 21:49:35 +0000 http://www.peterkrantz.com/?p=231#comment-2351 Yeah, I agree, with many parameters it gets complicated, and your patch works well for that case. For a typical site, most search queries will probably be new ones, so most people won't benefit from caching them. But I guess it doesn't hurt to cache them too. Yeah, I agree, with many parameters it gets complicated, and your patch works well for that case.

For a typical site, most search queries will probably be new ones, so most people won’t benefit from caching them. But I guess it doesn’t hurt to cache them too.

]]> By: Peter Krantz http://www.peterkrantz.com/2008/improving-django-cache-performance/comment-page-1/#comment-2350 Peter Krantz Mon, 03 Nov 2008 07:58:03 +0000 http://www.peterkrantz.com/?p=231#comment-2350 @Emil: It gets complicated to do slash-based URL:s if you have many combinations of parameters. Also, for a site where content changes slowly, I would expect to receive the same result for ?q=ponies over a short period of time (e.g. an hour) so I would definitely like that to get cached. Thanks for notifying me about the openid-stuff. Seems to be thoroughly broken right now. @Emil: It gets complicated to do slash-based URL:s if you have many combinations of parameters. Also, for a site where content changes slowly, I would expect to receive the same result for ?q=ponies over a short period of time (e.g. an hour) so I would definitely like that to get cached.

Thanks for notifying me about the openid-stuff. Seems to be thoroughly broken right now.

]]> By: Emil Stenström http://www.peterkrantz.com/2008/improving-django-cache-performance/comment-page-1/#comment-2349 Emil Stenström Sun, 02 Nov 2008 23:14:08 +0000 http://www.peterkrantz.com/?p=231#comment-2349 Also, OpenID is very much broken here. I logged in and got redirected to your wp-admin with the message that a user was created but that I couldn't log in. Message was lost :( Second time my name was saved in the OpenID field (how?) and my comment got lost again. Very annoying... Also, OpenID is very much broken here. I logged in and got redirected to your wp-admin with the message that a user was created but that I couldn’t log in. Message was lost :(

Second time my name was saved in the OpenID field (how?) and my comment got lost again.

Very annoying…

]]> By: Emil Stenström http://www.peterkrantz.com/2008/improving-django-cache-performance/comment-page-1/#comment-2348 Emil Stenström Sun, 02 Nov 2008 23:05:09 +0000 http://www.peterkrantz.com/?p=231#comment-2348 So you're already hacking away on the Django source :) That's clearly one success criteria of a open source project, to get smart people interested. In your specific case, you could have made your views not use get parameters: /items/sort/name/ or something like that, but I agree with you that the expected behavior is that GET params are cached too. When using the middleware sitewide cache I'm not sure we want the same behavior though, that would cache all searches (?q=ponies) too. Nice VPS site, will keep in mind when the play-around-hosting I use now expires. So you’re already hacking away on the Django source :) That’s clearly one success criteria of a open source project, to get smart people interested.

In your specific case, you could have made your views not use get parameters: /items/sort/name/ or something like that, but I agree with you that the expected behavior is that GET params are cached too. When using the middleware sitewide cache I’m not sure we want the same behavior though, that would cache all searches (?q=ponies) too.

Nice VPS site, will keep in mind when the play-around-hosting I use now expires.

]]> By: Joe http://www.peterkrantz.com/2008/improving-django-cache-performance/comment-page-1/#comment-2347 Joe Sun, 02 Nov 2008 20:17:53 +0000 http://www.peterkrantz.com/?p=231#comment-2347 The answer for me is -- don't cache views. Cache the data returned from queries, before sorting/processing/etc. -- joe The answer for me is — don’t cache views.
Cache the data returned from queries, before sorting/processing/etc.

– joe

]]>